Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sendable annotations to Crypto Extras #211

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

rnro
Copy link
Contributor

@rnro rnro commented Dec 11, 2023

Motivation

Add Sendable annotations to Crypto Extras to reflect current sandability so that downstream packages can implement sendable conformance.

Modifications

  • Add Sendable conformance to appropriate public symbols.
  • RSA public and private keys are notable omissions, this is because they are backed by SecKey from security framework and we have no guarantees about their sendability

Result

  • Accurate Sendable annotations

Motivation

Add Sendable annotations to Crypto Extras to reflect current sandability
so that downstream packages can implement sendable conformance.

Modifications

* Add Sendable conformance to appropriate public symbols.
* RSA public and private keys are notable omissions, this is because
  they are backed by SecKey from security framework and we have no
  guarantees about their sendability

Result

* Accurate Sendable annotations
@rnro rnro changed the title Add Sendables annotation to Crypto Extras Add Sendable annotations to Crypto Extras Dec 12, 2023
@dnadoba
Copy link
Member

dnadoba commented Dec 12, 2023

@swift-server-bot test this please

@dnadoba dnadoba merged commit ed66091 into apple:main Dec 12, 2023
8 checks passed
@rnro
Copy link
Contributor Author

rnro commented Dec 12, 2023

See #208

@Lukasa Lukasa added the 🆕 semver/minor Adds new public API. label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants