Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NIST PublicKeys conform to Equatable #174

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Sajjon
Copy link
Contributor

@Sajjon Sajjon commented Apr 17, 2023

Make NIST PublicKey's (P256, P384 and P521) conform to Equatable

Checklist

  • I've run tests to see all new and existing tests pass
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

If you've made changes to gyb files

  • I've run .script/generate_boilerplate_files_with_gyb and included updated generated files in a commit of this pull request

Motivation:

There is really no drawback in adding Equatable conformance, as argued in #173

Modifications:

  1. Make P256, P384 and P521's Signing and KeyAgreement PublicKey be Equatable, by...
  2. ... marking NISTECPublicKey to be Equatable and adding equals function in ECDH.swift.gyb
  3. Add tests for these.

Result:

ALL NIST PublicKey's now conform to Equatable

@Lukasa
Copy link
Contributor

Lukasa commented Apr 17, 2023

As with #173, I'm marking this as Request Changes just as a visual note to myself to return to it.

@Lukasa Lukasa closed this Apr 17, 2023
@Lukasa Lukasa reopened this Apr 17, 2023
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the right button this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants