Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "Unknown error" when configuring regions #11806

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

fix "Unknown error" when configuring regions #11806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions fdbclient/DatabaseConfiguration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,9 @@ std::string DatabaseConfiguration::configureStringFromJSON(const StatusObject& j
continue;
}

result += " ";
if (!result.empty()) {
result += " ";
}
// All integers are assumed to be actual DatabaseConfig keys and are set with
// the hidden "<name>:=<intValue>" syntax of the configure command.
if (kv.second.type() == json_spirit::int_type) {
Expand Down Expand Up @@ -449,7 +451,10 @@ std::string DatabaseConfiguration::configureStringFromJSON(const StatusObject& j
// explicit log_engine we simply add " log_engine=ssd-2" to the output string if the input JSON did not contain a
// log_engine.
if (!json.contains("log_engine")) {
result += " log_engine=ssd-2";
if (!result.empty()) {
result += " ";
}
result += "log_engine=ssd-2";
}

return result;
Expand Down