Rename error variable in go tests to err #8828 #11716

h4ck3r-04 · 2024-10-15T21:24:36Z

Renamed the variables from e to err as mentioned in the https://go.dev/doc/effective_go

According to the issue number #8828
the variables in go code were named using good and effective go practices.
Following the example link for reference mentioned in the issue the variables have been renamed.

renamed the variables from e to err as mentioned in the https://go.dev/doc/effective_go

foundationdb-ci · 2024-10-16T04:11:11Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 0e451b9
Duration 0:21:22
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-10-16T04:31:57Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 0e451b9
Duration 0:42:06
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-10-16T04:40:02Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 0e451b9
Duration 0:50:12
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-10-16T04:42:56Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 0e451b9
Duration 0:53:09
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-10-16T04:44:31Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 0e451b9
Duration 0:54:40
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2024-10-16T04:53:41Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 0e451b9
Duration 1:03:54
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-10-16T05:00:25Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 0e451b9
Duration 1:10:34
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

packaging/docker/samples/golang/app/main.go

vishesh

Minor nit. LGTM

foundationdb-ci · 2024-10-20T06:12:33Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 6a6a4e7
Duration 0:21:18
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-10-20T06:33:50Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 6a6a4e7
Duration 0:42:31
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-10-20T06:41:17Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 6a6a4e7
Duration 0:49:57
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-10-20T06:44:18Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 6a6a4e7
Duration 0:53:00
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-10-20T06:45:12Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 6a6a4e7
Duration 0:53:54
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2024-10-20T06:55:40Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 6a6a4e7
Duration 1:04:23
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-10-20T06:55:45Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 6a6a4e7
Duration 1:04:26
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

recipes/go-recipes/priority.go

bindings/go/src/fdb/directory/directoryLayer.go

gm42 · 2024-10-20T10:11:53Z

bindings/go/src/fdb/doc.go

-        fmt.Printf("hello is now world, foo was: %s\n", string(ret.([]byte)))
-    }
+	    fmt.Printf("hello is now world, foo was: %s\n", string(ret.([]byte)))
+	}


Are these whitespace changes intentional?

This might be because of the default formatter. They were not intentional

i have removed these whitespaces.

bindings/go/src/fdb/fdb.go

bindings/go/src/fdb/tuple/tuple.go

contrib/mockkms/get_encryption_keys.go

recipes/go-recipes/queue.go

gm42 · 2024-10-29T11:02:29Z

recipes/go-recipes/priority.go

 		}

 		if len(ks) == 0 {
 			return 0, nil
 		}
-		k, e := prty.PrioritySS.Unpack(ks[0].Key)
+		k, err := prty.PrioritySS.Unpack(ks[0].Key)


err here is ignored, should be evaluated.

i couldn't get it. could you come up once again.

Sure: I think this err is never returned to caller, so effectively is ignored.
But it's not something introduced by your PR, it just becomes evident due to the changes.

Assuming that k will be nil in the event of an error, that could cause an nil pointer exception.

bindings/go/src/fdb/fdb.go

gm42 · 2024-11-01T11:23:04Z

bindings/go/src/_stacktester/directory.go

@@ -115,7 +115,7 @@ func (de *DirectoryExtension) processOp(sm *StackMachine, op string, isDB bool,
 		}
 	}()

-	var e error


Can this be removed altogether?

gm42

Thanks for the changes!

foundationdb-ci · 2024-11-02T01:54:25Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 04b995a
Duration 0:04:33
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-11-02T01:54:28Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 04b995a
Duration 0:04:41
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-11-02T01:54:29Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 04b995a
Duration 0:04:40
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2024-11-02T01:54:32Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 04b995a
Duration 0:04:40
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-11-02T01:56:47Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 04b995a
Duration 0:06:58
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-11-02T01:56:50Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 04b995a
Duration 0:07:03
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-11-02T02:11:27Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 04b995a
Duration 0:21:40
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

jzhou77 · 2024-11-04T20:43:04Z

Looks like there are CI errors:

ninja: Entering directory `build_output'
[0/2] /usr/local/bin/cmake -P /codebuild/output/src805022784/src/github.com/apple/foundationdb/build_output/CMakeFiles/VerifyGlobs.cmake
ninja: error: '/codebuild/output/src805022784/src/github.com/apple/foundationdb/bindings/go/src/fdb/directory/directoryLayer.go', needed by 'bindings/go/src/github.com/apple/foundationdb/bindings/go/src/fdb/directory/directoryLayer.go', missing and no known rule to make it

bindings/go/CMakeLists.txt should be updated with file name changes.

johscheuer

Thanks for your PR. The next time it would be great to have two PR's for such things, e.g. one PR where you introduce the formatting and another PR where the variable is renamed, otherwise you'll have a huge PR which is hard to review.

johscheuer · 2024-11-05T14:12:00Z

bindings/go/src/fdb/directory/directory_layer.go

@@ -1,5 +1,5 @@
 /*
- * directoryLayer.go
+ * directory_layer.go


This change requires a change in the cmake setup, that's the reason why all tests are failing: https://github.com/apple/foundationdb/blob/main/bindings/go/CMakeLists.txt

johscheuer · 2024-11-05T14:12:47Z

bindings/go/src/fdb/directory/directory_partition.go

@@ -1,5 +1,5 @@
 /*
- * directoryPartition.go
+ * directory_partition.go


This change requires a change in the cmake setup, that's the reason why all tests are failing: https://github.com/apple/foundationdb/blob/main/bindings/go/CMakeLists.txt

johscheuer · 2024-11-05T14:12:50Z

bindings/go/src/fdb/directory/directory_subspace.go

@@ -1,5 +1,5 @@
 /*
- * directorySubspace.go
+ * directory_subspace.go


This change requires a change in the cmake setup, that's the reason why all tests are failing: https://github.com/apple/foundationdb/blob/main/bindings/go/CMakeLists.txt

johscheuer · 2024-11-05T14:18:11Z

bindings/go/src/fdb/directory/directory_subspace.go

@@ -90,7 +90,7 @@ func (d directorySubspace) Exists(rt fdb.ReadTransactor, path []string) (bool, e
 	return d.dl.Exists(rt, d.dl.partitionSubpath(d.path, path))
 }

-func (d directorySubspace) List(rt fdb.ReadTransactor, path []string) (subdirs []string, e error) {
+func (d directorySubspace) List(rt fdb.ReadTransactor, path []string) (subdirs []string, err error) {


Suggested change

func (d directorySubspace) List(rt fdb.ReadTransactor, path []string) (subdirs []string, err error) {

func (d directorySubspace) List(rt fdb.ReadTransactor, path []string) (]string, error) {

I don't see a reason why we need a named return value here.

johscheuer · 2024-11-05T16:36:31Z

recipes/go-recipes/priority.go

 		}

 		if len(ks) == 0 {
 			return 0, nil
 		}
-		k, e := prty.PrioritySS.Unpack(ks[0].Key)
+		k, err := prty.PrioritySS.Unpack(ks[0].Key)


Assuming that k will be nil in the event of an error, that could cause an nil pointer exception.

foundationdb-ci · 2024-11-11T09:43:51Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 5659f31
Duration 0:20:34
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-11-11T10:08:56Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 5659f31
Duration 0:45:12
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-11-11T10:13:20Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 5659f31
Duration 0:50:04
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-11-11T10:14:44Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 5659f31
Duration 0:51:25
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-11-11T10:19:27Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 5659f31
Duration 0:56:13
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2024-11-11T10:20:40Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 5659f31
Duration 0:57:20
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2024-11-11T10:25:38Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 5659f31
Duration 1:02:18
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

Rename error variable in go tests to err apple#8829

0e451b9

renamed the variables from e to err as mentioned in the https://go.dev/doc/effective_go

h4ck3r-04 changed the title ~~Rename error variable in go tests to err #8829~~ Rename error variable in go tests to err #8828 Oct 15, 2024

jzhou77 closed this Oct 16, 2024

jzhou77 reopened this Oct 16, 2024

jzhou77 requested a review from vishesh October 16, 2024 03:50

vishesh reviewed Oct 18, 2024

View reviewed changes

packaging/docker/samples/golang/app/main.go Outdated Show resolved Hide resolved

vishesh previously approved these changes Oct 18, 2024

View reviewed changes

Update packaging/docker/samples/golang/app/main.go

6a6a4e7

vishesh dismissed their stale review via 6a6a4e7 October 20, 2024 05:51

gm42 requested changes Oct 20, 2024

View reviewed changes

recipes/go-recipes/priority.go Outdated Show resolved Hide resolved