-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not run version vector with encryption-at-rest feature. #11646
base: main
Are you sure you want to change the base?
Conversation
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
@@ -815,6 +815,11 @@ inline bool shouldBackup(MutationRef const& m) { | |||
std::set<Tag> CommitBatchContext::getWrittenTagsPreResolution() { | |||
std::set<Tag> transactionTags; | |||
std::vector<Tag> cacheVector = { cacheTag }; | |||
// version vector is an experimental feature that does not support encryption at rest or backup. | |||
// This is indicated by returning an empty set of tags from this function. | |||
if (pProxyCommitData->encryptMode.isEncryptionEnabled()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it mean that the version vector won't get updated with the tags of these mutations or the mutations get sent to all logs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It ends up being the same behavior as a private transaction. The mutations get sent to all logs, and every tlog is included in the tpcv data structure. I am not sure writtenTags
is updated with all SS, though (and therefore the vv), so will investigate that and follow up.
Do not run version vector with encryption-at-rest feature.
With vv enabled, fixes:
tests/fast/EncryptionOps.toml --buggify on --seed 4126077204
Joshua (vv disabled)
20240910-183701-dlambrig-3e856b3aa52909e3
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)