Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner approach to generate _cocostuff_remap_info | Converted UnrecognizedYamlConfigEntry to Exception #34

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions corenet/options/errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
from corenet.constants import is_test_env


class UnrecognizedYamlConfigEntry(Warning):
# TODO: consider converting UnrecognizedYamlConfigEntry Warning to an Exception.
class UnrecognizedYamlConfigEntry(Exception):
# Throws exception when a key in yaml config is not recognized by argparser.
def __init__(self, key: str) -> None:
message = (
f"Yaml config key '{key}' was not recognized by argparser. If you think that you have already added "
Expand Down
191 changes: 15 additions & 176 deletions tools/converter_coco_stuff.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,184 +17,23 @@

from corenet.utils import logger

# Generates remaps for COCO-Stuff labels to 171 classes.
# Skips some of the labels that are not annotated.
def generate_cocostuff_remap():
cocostuff_skips = {11, 25, 28, 29, 44, 65, 67, 70, 82, 90, 179, 181} # IDs that are skipped
ErdajtSopjani marked this conversation as resolved.
Show resolved Hide resolved
remap_info = {}
new_id = 0
for old_id in range(182):
if old_id in cocostuff_skips:
continue
remap_info[old_id] = new_id
new_id += 1
remap_info[255] = 255 # Special case for the label 255
return remap_info

# State-of-the-art models use 171 classes for COCO-Stuff. This is because some of the labels defined in
# COCO-Stuff are not annotated. So, 182 cocostuff labels are remapped to 171 labels.
_cocostuff_remap_info = {
0: 0,
1: 1,
2: 2,
3: 3,
4: 4,
5: 5,
6: 6,
7: 7,
8: 8,
9: 9,
10: 10,
12: 11,
13: 12,
14: 13,
15: 14,
16: 15,
17: 16,
18: 17,
19: 18,
20: 19,
21: 20,
22: 21,
23: 22,
24: 23,
26: 24,
27: 25,
30: 26,
31: 27,
32: 28,
33: 29,
34: 30,
35: 31,
36: 32,
37: 33,
38: 34,
39: 35,
40: 36,
41: 37,
42: 38,
43: 39,
45: 40,
46: 41,
47: 42,
48: 43,
49: 44,
50: 45,
51: 46,
52: 47,
53: 48,
54: 49,
55: 50,
56: 51,
57: 52,
58: 53,
59: 54,
60: 55,
61: 56,
62: 57,
63: 58,
64: 59,
66: 60,
69: 61,
71: 62,
72: 63,
73: 64,
74: 65,
75: 66,
76: 67,
77: 68,
78: 69,
79: 70,
80: 71,
81: 72,
83: 73,
84: 74,
85: 75,
86: 76,
87: 77,
88: 78,
89: 79,
91: 80,
92: 81,
93: 82,
94: 83,
95: 84,
96: 85,
97: 86,
98: 87,
99: 88,
100: 89,
101: 90,
102: 91,
103: 92,
104: 93,
105: 94,
106: 95,
107: 96,
108: 97,
109: 98,
110: 99,
111: 100,
112: 101,
113: 102,
114: 103,
115: 104,
116: 105,
117: 106,
118: 107,
119: 108,
120: 109,
121: 110,
122: 111,
123: 112,
124: 113,
125: 114,
126: 115,
127: 116,
128: 117,
129: 118,
130: 119,
131: 120,
132: 121,
133: 122,
134: 123,
135: 124,
136: 125,
137: 126,
138: 127,
139: 128,
140: 129,
141: 130,
142: 131,
143: 132,
144: 133,
145: 134,
146: 135,
147: 136,
148: 137,
149: 138,
150: 139,
151: 140,
152: 141,
153: 142,
154: 143,
155: 144,
156: 145,
157: 146,
158: 147,
159: 148,
160: 149,
161: 150,
162: 151,
163: 152,
164: 153,
165: 154,
166: 155,
167: 156,
168: 157,
169: 158,
170: 159,
171: 160,
172: 161,
173: 162,
174: 163,
175: 164,
176: 165,
177: 166,
178: 167,
179: 168,
180: 169,
181: 170,
# 255 is not a label and is ignored during training.
255: 255,
}

_cocostuff_remap_info = generate_cocostuff_remap()

def remove_unannotated_mask_labels(src_path: str, dst_path: str) -> None:
"""Remap cocostuff labels.
Expand Down