Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove some leftover todos #580

Merged
merged 1 commit into from
Dec 8, 2024
+0 −25
Merged

chore: remove some leftover todos #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/appium_lib_core/common/base/driver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,6 @@ def add_command(method:, url:, name:, &block)
raise ::Appium::Core::Error::ArgumentError, "Available method is either #{AVAILABLE_METHODS}"
end

# TODO: Remove this logger before Appium 2.0 release
::Appium::Logger.info '[Experimental] this method is experimental for Appium 2.0. This interface may change.'

@bridge.add_command method: method, url: url, name: name, &block
end

Expand Down
16 changes: 0 additions & 16 deletions lib/appium_lib_core/driver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,12 +430,6 @@ def start_driver(server_url: nil,
@http_client.delete_additional_header Appium::Core::Base::Http::RequestHeaders::KEYS[:idempotency]
end

# TODO: this method can be removed after releasing Appium 2.0, and after a while
# since Appium 2.0 reuqires 'automationName'. This method won't help anymore then.
# If "automationName" is set only server side, this method set "automationName" attribute into @automation_name.
# Since @automation_name is set only client side before start_driver is called.
set_automation_name_if_nil

set_implicit_wait_by_default(@default_wait)

@driver
Expand Down Expand Up @@ -694,16 +688,6 @@ def convert_downcase(value)
value.is_a?(Symbol) ? value.downcase : value.downcase.strip.intern
end

# @private
def set_automation_name_if_nil
return unless @automation_name.nil?

automation_name = if @driver.capabilities['automationName']
@driver.capabilities['automationName'].downcase.strip.intern
end
@automation_name = convert_to_symbol automation_name
end

def get_cap(name)
name_with_prefix = "#{::Appium::Core::Base::Bridge::APPIUM_PREFIX}#{name}"
@caps[convert_to_symbol name] ||
Expand Down
2 changes: 0 additions & 2 deletions sig/lib/appium_lib_core/driver.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,6 @@ module Appium
def set_automation_name: () -> Symbol?

def convert_downcase: (Symbol value) -> Symbol

def set_automation_name_if_nil: () -> Symbol?
end
end
end
2 changes: 0 additions & 2 deletions test/functional/android/driver_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ def test_mobile_perform_action
new_element = @driver.find_element :xpath, '//*[@focused="true"]'
assert_equal 'Right is always right', new_element.text
end

# TODO: call @driver.quit after tests
end
end
# rubocop:enable Style/ClassVars
2 changes: 0 additions & 2 deletions test/functional/ios/driver_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,6 @@ def test_batch_combination_ruby_script
assert_equal(rect.width, r.result[1]['width'])
assert_equal(rect.height, r.result[1]['height'])
end

# TODO: call @driver.quit after tests
end
end
# rubocop:enable Style/ClassVars
Loading