feat: Add javascript wrappers over Settings App APIs #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Jan 9, 2024
I only add unit tests where necessary. Functional tests are not very stable :( |
Yes, of course I thought some of unit tests in test/unit/adb-commands-specs.js also can be copied. I'll copy if I find unit tests that tests the copied methods later as well |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
## [5.4.0](v5.3.1...v5.4.0) (2024-01-09) ### Features * Add javascript wrappers over Settings App APIs ([#131](#131)) ([bd56d5e](bd56d5e)) ### Bug Fixes * Add missing packages ([#132](#132)) ([7d3015a](7d3015a)) ### Miscellaneous Chores * **deps:** bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 ([#130](#130)) ([ae96723](ae96723))
|
🎉 This PR is included in version 5.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next step would be to switch clients to use calls from this module rather than appium-adb.
Eventually the duplicated stuff will be deprecated and cut-off from the latter, so this module would be the only owner of the functionality related to it.