-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: change method command on doubleTap code examples #2498
docs: change method command on doubleTap code examples #2498
Conversation
In the documentation of the mobile: doubleTap command, the mobile: pinch command was being used in the code examples.
|
This is my first pull request for an open source project, any suggestions would be appreciated. |
Thank you! Could you sign the CLA? |
I think I've done it now |
Thanks, but it looks like not yet...? The CLA checks git commit email address. It was |
Yes, now I see that I made the commit from another email. There you go, I have already done the process with that email. |
Thank you. Hm... does your login email is different from the signed email address..? Then, what happens when you create a new PR? |
Oh, nvm. The CI looks good |
🎉 This PR is included in version 7.33.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
In the documentation of the mobile: doubleTap command, the mobile: pinch command was being used in the code examples.