Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change method command on doubleTap code examples #2498

Merged

Conversation

Jefferson3038
Copy link
Contributor

In the documentation of the mobile: doubleTap command, the mobile: pinch command was being used in the code examples.
image

In the documentation of the mobile: doubleTap command, the mobile: pinch command was being used in the code examples.
Copy link

CLA Missing ID CLA Not Signed

@Jefferson3038
Copy link
Contributor Author

This is my first pull request for an open source project, any suggestions would be appreciated.

@KazuCocoa
Copy link
Member

Thank you! Could you sign the CLA?

@Jefferson3038
Copy link
Contributor Author

Thank you! Could you sign the CLA?

I think I've done it now

@KazuCocoa
Copy link
Member

Thanks, but it looks like not yet...? The CLA checks git commit email address. It was [email protected] so you may need to use the email address. @Jefferson3038
If you'd like to use another email address, the git commit also should be the email address

@Jefferson3038
Copy link
Contributor Author

Thanks, but it looks like not yet...? The CLA checks git commit email address. It was [email protected] so you may need to use the email address. @Jefferson3038 If you'd like to use another email address, the git commit also should be the email address

Yes, now I see that I made the commit from another email. There you go, I have already done the process with that email.

@KazuCocoa KazuCocoa changed the title fix: change method command on doubleTap code examples docs: change method command on doubleTap code examples Dec 7, 2024
@KazuCocoa
Copy link
Member

Thank you. Hm... does your login email is different from the signed email address..? Then, what happens when you create a new PR?

@KazuCocoa
Copy link
Member

Oh, nvm. The CI looks good

@KazuCocoa KazuCocoa merged commit 0c4ca8b into appium:master Dec 7, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented Dec 9, 2024

🎉 This PR is included in version 7.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants