feat: Allow specifying the /forcequit argument for WAD #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you @papauorg |
|
Hi @mykola-mokhnach, I adressed your comments for your ultra-fast review :) Thanks for that!
i did sign it. But to be honest it is kind of irritating to sign a 3 page contract for a contribution like this. |
papauorg
force-pushed
the
feature/wad-forcequit
branch
from
1c5d855 to
4270b44
Compare
Sorry for that, this CLA is common for all OSS projects under Linux Foundation. |
papauorg
force-pushed
the
feature/wad-forcequit
branch
from
4270b44 to
f779ac1
Compare
mykola-mokhnach
approved these changes
Nov 15, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
## [3.1.0](v3.0.2...v3.1.0) (2024-11-15) ### Features * Allow specifying the /forcequit argument for WAD ([#282](#282)) ([a9dda08](a9dda08))
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WinAppDriver supports a command line argument that will close the program under test ignoring any open windows or message boxes. This is very helpful for avoiding stale open applications in case the test did not properly clean up and close the program or an error occured during testing.
I extended the available capabilities by
ms:forcequitwhich can be specified by the test. It will then start the WinAppDriver with an additional argument/forcequitif set.