Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add appLocale capability #280

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Conversation

mykola-mokhnach
Copy link
Contributor

No description provided.

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, didn't know of measurements

[result addObject:[NSString stringWithFormat:@"<%@/>", appLocale[@"useMetricUnits"] ? @"true" : @"false"]];
}
if (nil != appLocale[@"measurementUnits"]) {
[result addObject:@"-AppleMeasurementUnits"];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, not sure how to test that though...

Copy link
Contributor Author

@mykola-mokhnach mykola-mokhnach Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to add it if you know how

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like AppleTemperatureUnit works for ios as well. processArguments/arguments is sufficient tho

@mykola-mokhnach mykola-mokhnach merged commit 3d65b66 into appium:master Feb 19, 2024
11 checks passed
@mykola-mokhnach mykola-mokhnach deleted the locale branch February 19, 2024 08:13
github-actions bot pushed a commit that referenced this pull request Feb 19, 2024
## [1.11.0](v1.10.2...v1.11.0) (2024-02-19)

### Features

* Add appLocale capability ([#280](#280)) ([3d65b66](3d65b66))
Copy link

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants