feat: support 'goog:loggingPrefs' value when creating a session #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
Aug 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
## [9.9.0](v9.8.3...v9.9.0) (2024-08-29) ### Features * support 'goog:loggingPrefs' value when creating a session ([#954](#954)) ([8392b89](8392b89))
|
🎉 This issue has been resolved in version 9.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi @pujagani, congrats, the Appium project wants to compensate you for this (and perhaps other) contribution(s) this month! Please reply to this comment mentioning me and sharing your OpenCollective account name, so that we can initiate payment! Or let me know if you decline to receive compensation via OpenCollective. Thank you! |
|
Thank you so much @jlipps! OpenCollective details : https://opencollective.com/pujagani |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Able to receive performance log types and get performance logs when using Mobile JSON Wire protocol but unable to do the same when using W3C.
Reason: The logging preferences are set using "goog:LoggingPrefs" in Selenium capability. "
[enablePerformanceLogging](https://github.com/appium/appium-android-driver/blob/92b51340cd976a73cb60530d6cdd6d43414b939a/lib/commands/context/helpers.js#L208)" is deprecated and Selenium 4 does not allow passing it. However, the Appium Android driver did not account for it and set it correctly to pass it to the Appium Chromedriver. Thus, the ChromeDriver would not receive it and then create a default session with the default logging preferences i.e.{browser: ALL}.Logs (when trying to use the Appium server):
Capabilities sent:
22024-08-28 14:12:36:753 - [HTTP] {"capabilities":{"firstMatch":[{"goog:chromeOptions":{"args":["--proxy-bypass-list=<-loopback>","test-type","--proxy-server=http://[REDACTED]","--disable-features=Translate"]},"newCommandTimeout":0,"goog:loggingPrefs":{"performance":"ALL"},"appium:skipServerInstallation":"true","platformName":"Android","deviceName":"android","browserName":"chrome"}]}}Capabilities when creating a ChromeDriver session capabilities:
Note that the capabilities sent while creating a ChromeDriver session do not contain the logging preferences:
"performance": "ALL”but only the default value"browser": "ALL". This change fixes it in the Android appium driver.