Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for activities with multilingual chars #767

Closed

Conversation

tomaskatz96
Copy link

No description provided.

Copy link

linux-foundation-easycla bot commented Nov 3, 2024

CLA Not Signed

@mykola-mokhnach
Copy link
Contributor

Thank you @tomaskatz96

Please sign the CLA and add a unit test to verify your change

@tomaskatz96 tomaskatz96 changed the title Added support for activities with multilingual chars chore: Added support for activities with multilingual chars Nov 4, 2024
@tomaskatz96 tomaskatz96 changed the title chore: Added support for activities with multilingual chars feat: Added support for activities with multilingual chars Nov 4, 2024
@tomaskatz96
Copy link
Author

Hi @mykola-mokhnach,
Added tests and signed the CLA

@mykola-mokhnach
Copy link
Contributor

Added tests and signed the CLA

Could you please maybe squash commits and/or make sure they were done using the same email address that was used to sign the CLA?

@tomaskatz96
Copy link
Author

@mykola-mokhnach Do I need to open new PR with all the changes and close this one?

@KazuCocoa
Copy link
Member

Probably it makes sense to create a new one, although, the CLA checks the commit user's email. Please make sure your commit email is the same as what you use for the sign.

e.g.

$ git log
commit 4f1e8d0 (grafted, HEAD -> add_multilingual_support, origin/add_multilingual_support)
Author: tomaskatz96 [email protected]

@tomaskatz96 tomaskatz96 closed this Nov 4, 2024
@tomaskatz96 tomaskatz96 deleted the add_multilingual_support branch November 5, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants