feat: add support for activities with unicode chars (#773)

appium · Nov 10, 2024 · 8494f72 · 8494f72
1 parent 321cc93
commit 8494f72
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/helpers.js b/lib/helpers.js
@@ -1005,7 +1005,7 @@ function parseLaunchableActivityNames (dumpsys) {
  */
 function matchComponentName (classString) {
   // some.package/some.package.Activity
-  return /^[a-z0-9./_]+$/i.exec(classString);
+  return /^[\p{L}0-9./_]+$/u.exec(classString);
 }
 
 /**

diff --git a/test/unit/helper-specs.js b/test/unit/helper-specs.js
@@ -2,7 +2,7 @@ import {
   getAndroidPlatformAndPath,
   buildStartCmd, isShowingLockscreen, getBuildToolsDirs,
   parseAaptStrings, parseAapt2Strings,
-  extractMatchingPermissions, parseLaunchableActivityNames,
+  extractMatchingPermissions, parseLaunchableActivityNames, matchComponentName,
 } from '../../lib/helpers';
 import { withMocks } from '@appium/test-support';
 import { fs } from '@appium/support';
@@ -480,4 +480,16 @@ describe('helpers', withMocks({fs}, function (mocks) {
       names.should.be.eql([]);
     });
   });
+  describe('matchComponentName', function () {
+    it('test valid activity name', function () {
+      const activity = 'ןذأצЮυπиС.נפשוקשΤπΟ.ЦοКسئοهΦΦ';
+      const names = matchComponentName(activity);
+      names.should.eql([activity]);
+    });
+    it('test invalid activity name', function () {
+      const activity = 'User@123';
+      _.isNull(matchComponentName(activity)).should.be.true;
+    });
+
+  });
 }));