[tvOS]2nd: tvos build #149

KazuCocoa · 2019-03-21T09:33:16Z

2nd one for #148

This PR aims to build with tvOS scheme.
(I've added the scheme build on travis. So, Travis is green means tvOS build succeeds)

KazuCocoa#4 will come after this PR.
I'll add comments where will change in the next PR.

This PR is mainly add !TARGET_OS_TV to avoid libraries which are not included in tvOS

note:

Xcode 9.2 on Travis has no tvOS device.

xcodebuild: error: Unable to find a destination matching the provided destination specifier:
		{ OS:11.2, name:Apple TV }
	Ineligible destinations for the "WebDriverAgentRunner_tvOS" scheme:
		{ platform:tvOS, id:dvtdevice-DVTiOSDevicePlaceholder-appletvos:placeholder, name:Generic tvOS Device }
		{ platform:tvOS Simulator, id:dvtdevice-DVTiOSDeviceSimulatorPlaceholder-appletvsimulator:placeholder, name:Generic tvOS Simulator Device }
The command "./Scripts/build.sh" exited with 1.

KazuCocoa · 2019-03-21T09:33:52Z

Cartfile

@@ -2,7 +2,7 @@
 github "appium/RoutingHTTPServer"

 # Used by the element cache
-github "appium/YYCache"
+github "KazuCocoa/YYCache" "add-tvos-support"


Will change to appium/YYCache after appium/YYCache#1

KazuCocoa · 2019-03-21T09:34:56Z

WebDriverAgentLib/Categories/XCUIApplication+FBFocused.h

+  /**
+   Return current focused element
+   */
+- (id<FBElement>) fb_focusedElement;


Will move into XCUIApplication+FBHelpers.h in the next PR like https://github.com/KazuCocoa/WebDriverAgent/pull/4/files#diff-b4b112241fad0f90c09864fbe40aef25R56

KazuCocoa · 2019-03-21T09:35:16Z

WebDriverAgentLib/Categories/XCUIApplication+FBFocused.m

+
+@implementation XCUIApplication (FBFocused)
+
+- (id<FBElement>) fb_focusedElement


Will move into XCUIApplication+FBHelpers.m in the next PR

KazuCocoa · 2019-03-21T09:37:56Z

WebDriverAgentLib/Categories/XCUIElement+FBWebDriverAttributes.m

@@ -191,6 +191,15 @@ - (BOOL)isWDVisible
  return [[self fb_cachedValueWithAttributeName:@"isWDVisible" valueGetter:getter] boolValue];
 }

+#if TARGET_OS_TV


Will remove since hasFocus is included in iPhone as well.
(I noticed after this change...)
https://developer.apple.com/documentation/xctest/xcuielementattributes/1627636-hasfocus

KazuCocoa · 2019-03-21T09:39:11Z

WebDriverAgentLib/Utilities/FBTVNavigationTracker.m

+
+- (FBTVDirection)directionToMoveFocuse
+{
+  id<FBElement> focused = self.focusedElement;


FBElement will change to XCUIElement in the next PR like https://github.com/KazuCocoa/WebDriverAgent/pull/4/files#diff-ca69d06a77426842d4a7b3c34bfcedc4R44

mykola-mokhnach · 2019-03-22T06:14:44Z

WebDriverAgentLib/Categories/XCUIElement+FBTVFocuse.h

+#if TARGET_OS_TV
+@interface XCUIElement (FBTVFocuse)
+
+-(BOOL)fb_focuseWithError:(NSError**) error;


focuse -> setFocus

docstrings are missing

mykola-mokhnach · 2019-03-22T06:15:04Z

WebDriverAgentLib/Categories/XCUIElement+FBTVFocuse.h

+
+-(BOOL)fb_focuseWithError:(NSError**) error;
+
+-(BOOL)fb_selectWithError:(NSError**) error;


There should be a space after - or +

mykola-mokhnach · 2019-03-22T06:16:13Z

WebDriverAgentLib/Categories/XCUIElement+FBTVFocuse.m

+-(BOOL)fb_focuseWithError:(NSError**) error
+{
+  [[FBApplication fb_activeApplication] fb_waitUntilSnapshotIsStable];
+  if (self.wdEnabled) {


Id' rather make the condition block shorter by checking !self.wdEnabled

mykola-mokhnach · 2019-03-22T06:16:57Z

WebDriverAgentLib/Categories/XCUIElement+FBTVFocuse.m

+      }
+      if (self.exists) {
+        FBTVDirection direction = tracker.directionToMoveFocuse;
+        if(direction != FBTVDirectionNone) {


missing space

KazuCocoa · 2019-03-22T06:17:08Z

Will update YYCache soon

mykola-mokhnach · 2019-03-22T06:17:44Z

WebDriverAgentLib/Categories/XCUIElement+FBTVFocuse.m

+          continue;
+        }
+      }
+      [[[FBErrorBuilder builder] withDescription:@"Unable to reach element. Try to use XCUIRemote commands."]


I'd also put element.desciption into the error message

mykola-mokhnach · 2019-03-22T06:22:18Z

WebDriverAgentLib/FBSpringboardApplication.m

@@ -36,6 +42,19 @@ + (instancetype)fb_springboard
  return _springboardApp;
 }

+/**
+ * Returns proper identifier


is this docstring correct?

mykola-mokhnach · 2019-03-22T06:23:51Z

WebDriverAgentLib/FBSpringboardApplication.m

+  if (![appElement fb_selectWithError:error]) {
+    return NO;
+  }
+  [[XCUIRemote sharedRemote] pressButton: XCUIRemoteButtonSelect];


isn't fb_selectWithError already pressing XCUIRemoteButtonSelect ?

mykola-mokhnach · 2019-03-22T06:25:51Z

WebDriverAgentLib/FBSpringboardApplication.m

@@ -99,9 +147,13 @@ - (BOOL)fb_waitUntilApplicationBoardIsVisible:(NSError **)error
 - (BOOL)fb_isApplicationBoardVisible
 {
  [self resolve];
+#if TARGET_OS_TV
+  return self.collectionViews[@"GridCollectionView"].isEnabled;


is GridCollectionView precise?

So far, yes since like below...
I need to make sure "HomeBoard" in the application class can use for it, maybe...

so far, the GridCollectionView looks the most reasonable... at least, it appears on the top...

WebDriverAgentLib/Utilities/FBTVNavigationTracker.h

mykola-mokhnach · 2019-03-22T06:28:50Z

WebDriverAgentLib/Utilities/FBTVNavigationTracker.m

+#import "XCUIElement+FBWebDriverAttributes.h"
+
+@interface FBTVNavigationItem : NSObject
+@property (nonatomic, assign) NSUInteger uid;


mykola-mokhnach · 2019-03-22T06:29:31Z

WebDriverAgentLib/Utilities/FBTVNavigationTracker.m

+  CGFloat yDelta = self.targetCenter.y - focusedCenter.y;
+  CGFloat xDelta = self.targetCenter.x - focusedCenter.x;
+  FBTVDirection direction;
+  if(fabs(yDelta) > fabs(xDelta)) {


space after if

mykola-mokhnach · 2019-03-22T06:29:58Z

WebDriverAgentLib/Utilities/FBTVNavigationTracker.m

+  return [FBApplication fb_activeApplication].fb_focusedElement;
+}
+
+-(FBTVNavigationItem*) navigationItemFromElement:(id<FBElement>)element


space after -

mykola-mokhnach · 2019-03-22T06:32:15Z

WebDriverAgentLib/Categories/XCUIElement+FBWebDriverAttributes.m

+
+- (BOOL)isWDFocused
+{
+  return self.hasFocus;


should the value of the attribute be cached?

WebDriverAgentLib copy-Info.plist

WebDriverAgentLib/Categories/XCUIElement+FBTVFocuse.h

WebDriverAgentLib/Categories/XCUIApplication+FBFocused.h

WebDriverAgentLib/Categories/XCUIElement+FBTyping.m

WebDriverAgentLib/FBSpringboardApplication.h

WebDriverAgentLib/Utilities/FBTVNavigationTracker.h

WebDriverAgentLib/Utilities/FBTVNavigationTracker.m

WebDriverAgentLib/Utilities/FBTVNavigationTracker.h

WebDriverAgentLib/Utilities/FBTVNavigationTracker.m

WebDriverAgentLib/Categories/XCUIElement+FBTVFocuse.m

mykola-mokhnach · 2019-03-23T07:44:19Z

WebDriverAgentLib/Utilities/FBTVNavigationTracker.m

+  return self;
+}
+
+- (FBTVDirection)directionToFocusedElement


this method is a classic example of the path finding algorithm. It would be nice to cover it with unit tests in the next PRs

WebDriverAgentLib/FBSpringboardApplication.m

mykola-mokhnach

I like the PR. Only some minor things are left to fix

WebDriverAgentLib/Categories/XCUIElement+FBTVFocuse.m

KazuCocoa added 5 commits March 21, 2019 17:15

make tvos buildable

f18f73e

remove tvOS tests since currently they does not work

55cea02

fix screenshot

8ac396a

tweak target os tv

c247ab2

add travis

40a7096

KazuCocoa commented Mar 21, 2019

View reviewed changes

get rid of xcode9.2 build because of no destination

83b5b2e

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/Utilities/FBTVNavigationTracker.h Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/Utilities/FBTVNavigationTracker.h Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

KazuCocoa added 5 commits March 22, 2019 18:19

update yycache to use 1.1.0

b22c296

fix fbtvfocuse

23c22dd

fix FBSpringboardApplication

b78b1b7

cache hasFocuse

cd64a4c

fix FBTVNavigationTracker

9c8043b

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib copy-Info.plist Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/Categories/XCUIElement+FBTVFocuse.h Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/Categories/XCUIApplication+FBFocused.h Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/Categories/XCUIElement+FBTyping.m Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/FBSpringboardApplication.h Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/Utilities/FBTVNavigationTracker.h Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/Utilities/FBTVNavigationTracker.h Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/Utilities/FBTVNavigationTracker.h Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/Utilities/FBTVNavigationTracker.m Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/Utilities/FBTVNavigationTracker.h Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/Utilities/FBTVNavigationTracker.m Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/Utilities/FBTVNavigationTracker.m Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/Utilities/FBTVNavigationTracker.m Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/Utilities/FBTVNavigationTracker.m Show resolved Hide resolved

mykola-mokhnach reviewed Mar 22, 2019

View reviewed changes

WebDriverAgentLib/Utilities/FBTVNavigationTracker.m Outdated Show resolved Hide resolved

KazuCocoa added 2 commits March 23, 2019 12:08

fix review

5f67634

arrange indentations, enable isWDFocused for both ios and tvos

4a22b19

mykola-mokhnach reviewed Mar 23, 2019

View reviewed changes

WebDriverAgentLib/Categories/XCUIElement+FBTVFocuse.m Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Mar 23, 2019

View reviewed changes

WebDriverAgentLib/Categories/XCUIElement+FBTVFocuse.m Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Mar 23, 2019

View reviewed changes

WebDriverAgentLib/FBSpringboardApplication.m Outdated Show resolved Hide resolved

mykola-mokhnach approved these changes Mar 23, 2019

View reviewed changes

KazuCocoa added 2 commits March 23, 2019 18:25

arrange func names, deltas

d7215bd

add self.description into error messages

b1b1ab8

mykola-mokhnach reviewed Mar 23, 2019

View reviewed changes

WebDriverAgentLib/Categories/XCUIElement+FBTVFocuse.m Outdated Show resolved Hide resolved

tweak message

8832197

KazuCocoa merged commit 1173666 into appium:master Mar 24, 2019

KazuCocoa mentioned this pull request Mar 30, 2019

Port tvOS headers #141

Closed

KazuCocoa deleted the tvos-build branch March 30, 2019 06:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tvOS]2nd: tvos build #149

[tvOS]2nd: tvos build #149

KazuCocoa commented Mar 21, 2019 •

edited

Loading

KazuCocoa Mar 21, 2019

KazuCocoa Mar 21, 2019

KazuCocoa Mar 21, 2019

KazuCocoa Mar 21, 2019

KazuCocoa Mar 21, 2019

mykola-mokhnach Mar 22, 2019

mykola-mokhnach Mar 22, 2019

mykola-mokhnach Mar 22, 2019

mykola-mokhnach Mar 22, 2019

mykola-mokhnach Mar 22, 2019

KazuCocoa commented Mar 22, 2019

mykola-mokhnach Mar 22, 2019

mykola-mokhnach Mar 22, 2019

mykola-mokhnach Mar 22, 2019

mykola-mokhnach Mar 22, 2019

KazuCocoa Mar 22, 2019

KazuCocoa Mar 22, 2019

mykola-mokhnach Mar 22, 2019

mykola-mokhnach Mar 22, 2019

mykola-mokhnach Mar 22, 2019

mykola-mokhnach Mar 22, 2019

mykola-mokhnach Mar 23, 2019 •

edited

Loading

mykola-mokhnach left a comment


		@implementation XCUIApplication (FBFocused)

		- (id<FBElement>) fb_focusedElement


		-(BOOL)fb_focuseWithError:(NSError**) error;

		-(BOOL)fb_selectWithError:(NSError**) error;

[tvOS]2nd: tvos build #149

[tvOS]2nd: tvos build #149

Conversation

KazuCocoa commented Mar 21, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KazuCocoa commented Mar 22, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mykola-mokhnach Mar 23, 2019 • edited Loading

Choose a reason for hiding this comment

mykola-mokhnach left a comment

Choose a reason for hiding this comment

KazuCocoa commented Mar 21, 2019 •

edited

Loading

mykola-mokhnach Mar 23, 2019 •

edited

Loading