Skip to content

fix: replaced MinioClient to IMinioClient in HealthChecks #115

fix: replaced MinioClient to IMinioClient in HealthChecks

fix: replaced MinioClient to IMinioClient in HealthChecks #115

Re-run triggered June 24, 2024 19:59
Status Success
Total duration 44s
Artifacts

tests.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-dotnet@v3, codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Tests: src/Minio.AspNetCore/MinioOptions.cs#L5
Instance of NullForgiving operator without justification detected (https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/operators/null-forgiving)
Tests: src/Minio.AspNetCore/MinioOptions.cs#L5
Instance of NullForgiving operator without justification detected (https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/operators/null-forgiving)
Tests: src/Minio.AspNetCore/MinioOptions.cs#L5
Instance of NullForgiving operator without justification detected (https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/operators/null-forgiving)
Tests: src/Minio.AspNetCore.HealthChecks/MinioHealthChecksExtensions.cs#L22
Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1510)
Tests: src/Minio.AspNetCore.HealthChecks/MinioHealthCheck.cs#L28
Modify 'CheckHealthAsync' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
Tests: src/Minio.AspNetCore.HealthChecks/MinioHealthCheck.cs#L28
Modify 'CheckHealthAsync' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
Tests: tests/ServiceCollectionUrlExtensionsTests.cs#L47
Change the type of parameter 'url' of method 'ServiceCollectionUrlExtensionsTests.UrlBasedConfigurationInvalidCredentialsThrow(string)' from 'string' to 'System.Uri', or provide an overload to 'ServiceCollectionUrlExtensionsTests.UrlBasedConfigurationInvalidCredentialsThrow(string)' that allows 'url' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
Tests: src/Minio.AspNetCore.HealthChecks/MinioHealthChecksExtensions.cs#L22
Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1510)
Tests: src/Minio.AspNetCore.HealthChecks/MinioHealthCheck.cs#L28
Modify 'CheckHealthAsync' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)