Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frontend support for video memes #232

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

julian-ao
Copy link
Member

@julian-ao julian-ao commented Dec 19, 2024

Added a <video>-tag for memes that are of type "video". Did this for movember-page aswell

@julian-ao julian-ao added bug Something isn't working enhancement New feature or request frontend labels Dec 19, 2024
@julian-ao julian-ao requested a review from fredrir December 19, 2024 16:33
@julian-ao julian-ao self-assigned this Dec 19, 2024
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
infoskjerm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 10:00pm
infoskjerm-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 10:00pm

@fredrir
Copy link
Member

fredrir commented Dec 19, 2024

Kanskje gjøre det samme for movember i samme slengen?

@julian-ao
Copy link
Member Author

Lurt



if (imageError) {
if (meidaError) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (meidaError) {
if (mediaError) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants