Add mocks for a basic set of operations to work with GraphOS demo #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we need graph id to make identifier unique
Based on ad-blockers and the modern internet, we can't rely on referrer to uniquely identify demos and make the mocked data work independently from each other
More mocks will need to be added in the future with additional tests
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
jerelmiller
requested changes
Jul 20, 2023
There was a problem hiding this comment.
This is great! Will be nice to be able to try out the API without the token. Appreciate you putting this in there!
The biggest thing I could see as a potential pitfall is the sharing of the mocks object between all users, which would clobber each other's state.
…g existing object
…to guarantee state creation. Use this.state everywhere and remove conditional checks on it.
jerelmiller
approved these changes
Jul 21, 2023
…/spotify-showcase into mock-subscriptions
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.