Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement serde for basic AST types #760

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Implement serde for basic AST types #760

merged 5 commits into from
Nov 30, 2023

Conversation

SimonSapin
Copy link
Contributor

Extracted from #758
Fixes #735

@SimonSapin SimonSapin self-assigned this Nov 28, 2023
goto-bus-stop
goto-bus-stop approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, just some copy comments

crates/apollo-compiler/CHANGELOG.md Outdated Show resolved Hide resolved
crates/apollo-compiler/CHANGELOG.md Outdated Show resolved Hide resolved
crates/apollo-compiler/src/ast/impls.rs Outdated Show resolved Hide resolved
crates/apollo-compiler/src/ast/impls.rs Outdated Show resolved Hide resolved
crates/apollo-compiler/src/ast/impls.rs Outdated Show resolved Hide resolved
@SimonSapin
Copy link
Contributor Author

All added impls for ast::Type which the Router could use. Carrying the previous review since they’re simply derived.

@SimonSapin SimonSapin enabled auto-merge (squash) November 30, 2023 11:33
@SimonSapin SimonSapin merged commit 90d48b6 into main Nov 30, 2023
11 checks passed
@SimonSapin SimonSapin deleted the serde-impls branch November 30, 2023 11:38
@goto-bus-stop goto-bus-stop mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goto-bus-stop goto-bus-stop goto-bus-stop approved these changes

@lrlna lrlna Awaiting requested review from lrlna lrlna is a code owner

Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make some compiler types serde-serializable
2 participants
@SimonSapin @goto-bus-stop