Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Adds missing peer dependency #1196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

arcanis
Copy link

@arcanis arcanis commented Nov 11, 2019

apollo-link-error has a transitive peer dependency on graphql through apollo-link, and must be marked as such. Cf my article why implicit transitive peer dependencies are bad 🙂

As long as you're here, can you please give a look to the following related PRs? 😃

@apollo-cla
Copy link

@arcanis: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@codecov-io
Copy link

codecov-io commented Nov 11, 2019

Codecov Report

Merging #1196 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1196   +/-   ##
======================================
  Coverage    95.6%   95.6%           
======================================
  Files          22      22           
  Lines        1116    1116           
  Branches      174     162   -12     
======================================
  Hits         1067    1067           
  Misses         44      44           
  Partials        5       5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdef549...60e98d1. Read the comment docs.

@cometkim
Copy link

cometkim commented Apr 1, 2020

And there are few more; apollo-link-context also doesn't have peerDeps.

I can't use apollo with yarn 2 because of this. Any plan to update?

@cometkim cometkim mentioned this pull request Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants