Skip to content
This repository has been archived by the owner on Jul 10, 2019. It is now read-only.

Fix: when alias returns a falsy value, it may return undefined #303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: when alias returns a falsy value, it may return undefined #303

wants to merge 1 commit into from

Conversation

jimmycallin
Copy link

Hi! I had an aliased field vanishing from the local state, which after some investigation seem to have been solved by splitting up the return statement as shown in this PR.

@apollo-cla
Copy link

@jimmycallin: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@ghost ghost added the blocking Prevents production or dev due to perf, bug, build error, etc.. label Sep 23, 2018
@codecov-io
Copy link

codecov-io commented Sep 23, 2018

Codecov Report

Merging #303 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage      95%   95.12%   +0.12%     
==========================================
  Files           2        2              
  Lines          80       82       +2     
  Branches       26       26              
==========================================
+ Hits           76       78       +2     
  Misses          1        1              
  Partials        3        3
Impacted Files Coverage Δ
packages/apollo-link-state/src/index.ts 93.84% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5930a...85102fb. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking Prevents production or dev due to perf, bug, build error, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants