Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop blocking duplicate renders based on skip settings #6587

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Stop blocking duplicate renders based on skip settings #6587

merged 2 commits into from
Jul 13, 2020

Conversation

hwillson
Copy link
Member

Recent Apollo Client core refactoring has made it unnecessary to attempt to block duplicate useQuery renders when skip is true.

Fixes #5877

@hwillson hwillson self-assigned this Jul 13, 2020
@hwillson hwillson added this to the Release 3.0 milestone Jul 13, 2020
@hwillson hwillson requested review from benjamn and jcreighton July 13, 2020 13:49
@hwillson
Stop blocking duplicate renders based on skip settings
d66de66 
Recent Apollo Client core refactoring has made it unnecessary
to attempt to block duplicate `useQuery` renders when `skip`
is `true`.

Fixes #5877
benjamn
benjamn approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit with some style tweaks, but LGTM.

@benjamn benjamn merged commit 9fa06cd into master Jul 13, 2020
@benjamn benjamn deleted the issue-5877 branch July 13, 2020 14:16
@imdadul
Copy link

imdadul commented Jul 17, 2020

As mentioned in this issue,
in useQuery even though skip is true, the query is executing.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjamn benjamn benjamn approved these changes

@jcreighton jcreighton Awaiting requested review from jcreighton

Assignees

@hwillson hwillson

Labels
🐞 bug ⚛️ React-related
Projects
None yet
Milestone
Release 3.0
Development

Successfully merging this pull request may close these issues.

[3.0-beta] Changing skip to true on a hook ignores results from "fast" data sources
3 participants
@hwillson @imdadul @benjamn