Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canary test adjustments #12233

Merged
merged 5 commits into from
Dec 18, 2024
Merged

canary test adjustments #12233

merged 5 commits into from
Dec 18, 2024

Conversation

phryneas
Copy link
Member

Leaving this up for review of the whole action.

@svc-apollo-docs
Copy link

svc-apollo-docs commented Dec 18, 2024

✅ Docs Preview Ready

No new or changed pages found.

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: f5940b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Dec 18, 2024

npm i https://pkg.pr.new/@apollo/client@12233

commit: f5940b7

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit f5940b7
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/6762cfb3f1434700085432e3
😎 Deploy Preview https://deploy-preview-12233--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 18, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 40.64 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 50.02 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 47.14 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.13 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.54 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.3 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.7 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.78 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.84 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.42 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.41 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.35 KB (0%)
import { useFragment } from "dist/react/index.js" 2.36 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.31 KB (0%)

@phryneas phryneas requested a review from jerelmiller December 18, 2024 12:52
@phryneas phryneas marked this pull request as ready for review December 18, 2024 12:52
Comment on lines 17 to 20
branch:
- main
- release-3.13
- release-4.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I unfortunately don't see an easy way around hardcoding these.

Comment on lines +8 to +16
inputs:
branches:
description: "Branches to test"
required: true
default: '["main", "release-3.13", "release-4.0"]'
tags:
description: "React and React-DOM versions"
required: true
default: '["canary", "experimental"]'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows us to manually run against different targets - see https://github.com/apollographql/apollo-client/actions/runs/12394062292 as an example run that only ran against one different branch.

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@github-actions github-actions bot added the auto-cleanup 🤖 label Dec 18, 2024
@phryneas phryneas merged commit 2fb7d7a into main Dec 18, 2024
50 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants