Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rc from stable version #12209

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zoosissoos
Copy link

removed "rc" from stable version fixing peer-deps for npm ci

@apollo-cla
Copy link

@zoosissoos: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

netlify bot commented Dec 11, 2024

👷 Deploy request for apollo-client-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a9eacc9

Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: a9eacc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svc-apollo-docs
Copy link

svc-apollo-docs commented Dec 11, 2024

✅ Docs Preview Ready

No new or changed pages found.

@jerelmiller
Copy link
Member

Hey @zoosissoos 👋

What issue are you seeing installing with this version range? We are intentionally leaving this in there for a few patch versions to allow those who were using Apollo Client with the React rc versions to continue to work. According to semver.npmjs.com this version range includes 19.0.0 as well. Any more information you can provide?

@zoosissoos
Copy link
Author

zoosissoos commented Dec 12, 2024

Hey @zoosissoos 👋

What issue are you seeing installing with this version range? We are intentionally leaving this in there for a few patch versions to allow those who were using Apollo Client with the React rc versions to continue to work. According to semver.npmjs.com this version range includes 19.0.0 as well. Any more information you can provide?

I am trying to migrate our team from React 18.3 -> 19.x.x When performing an npm install I was receiving this error.
I assumed it was because I thinking 19.0.0 < 19.0.0-rc.
After looking into this further I realize it must be because of another package (@react-google-maps/[email protected]) and not Apollo. I'm sorry for the inconvenience if I was incorrect.

npm error While resolving: @react-google-maps/[email protected]

npm error Found: [email protected]

npm error node_modules/react

npm error   react@"19.0.0" from the root project 

npm error   peerOptional react@"^16.8.0 || ^17.0.0 || ^18.0.0 || >=19.0.0-rc" from @apollo/[email protected].   <<<<<-------

npm error   node_modules/@apollo/client

npm error     @apollo/client@"^3.12.2" from the root project

npm error   26 more (@react-hook/latest, ...)

npm error

@phryneas
Copy link
Member

phryneas commented Dec 12, 2024

Could you maybe share that package.json and lockfile so we can try that locally? According to npm's own tools, this should not result in any problems.
The problem is: if we remove the rc, we will actually break people who are still on those rcs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants