-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove itAsync
part 1
#12182
Remove itAsync
part 1
#12182
Conversation
|
✅ Docs Preview ReadyNo new or changed pages found. |
commit: |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
4489363
to
8fdd503
Compare
unsubscribe() { | ||
this.subscription.unsubscribe(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. We could also make it implement Disposable
and use it with using
in tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like a good idea. I don't see any reason we shouldn't do that. I'll do that in a separate PR though so we can get a few tests updated to using
without the noise of all these changes around it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few more nitpicks, then LGTM
This is part 1 of refactoring all tests to move away from
itAsync
and to use the standard built-init
helper from Jest.This is the first of such PRs so we can make some progress.