Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove itAsync part 1 #12182

Merged
merged 30 commits into from
Dec 12, 2024
Merged

Remove itAsync part 1 #12182

merged 30 commits into from
Dec 12, 2024

Conversation

jerelmiller
Copy link
Member

@jerelmiller jerelmiller commented Dec 6, 2024

This is part 1 of refactoring all tests to move away from itAsync and to use the standard built-in it helper from Jest.

This is the first of such PRs so we can make some progress.

@jerelmiller jerelmiller requested a review from phryneas December 6, 2024 23:09
Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: c66675e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svc-apollo-docs
Copy link

svc-apollo-docs commented Dec 6, 2024

✅ Docs Preview Ready

No new or changed pages found.

Copy link

pkg-pr-new bot commented Dec 6, 2024

npm i https://pkg.pr.new/@apollo/client@12182

commit: c66675e

Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit c66675e
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/675b2070b51bb60008e274df
😎 Deploy Preview https://deploy-preview-12182--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 40.64 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 50.02 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 47.14 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.13 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.54 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.3 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.7 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.78 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.84 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.42 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.41 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.35 KB (0%)
import { useFragment } from "dist/react/index.js" 2.36 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.31 KB (0%)

@jerelmiller jerelmiller force-pushed the jerel/remove-itasync-part-1 branch from 4489363 to 8fdd503 Compare December 7, 2024 00:15
src/__tests__/client.ts Outdated Show resolved Hide resolved
src/__tests__/client.ts Outdated Show resolved Hide resolved
src/__tests__/client.ts Outdated Show resolved Hide resolved
src/__tests__/client.ts Outdated Show resolved Hide resolved
src/__tests__/client.ts Outdated Show resolved Hide resolved
src/link/error/__tests__/index.ts Outdated Show resolved Hide resolved
src/link/error/__tests__/index.ts Outdated Show resolved Hide resolved
Comment on lines +44 to +46
unsubscribe() {
this.subscription.unsubscribe();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. We could also make it implement Disposable and use it with using in tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a good idea. I don't see any reason we shouldn't do that. I'll do that in a separate PR though so we can get a few tests updated to using without the noise of all these changes around it.

Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more nitpicks, then LGTM

@github-actions github-actions bot added the auto-cleanup 🤖 label Dec 12, 2024
@jerelmiller jerelmiller merged commit 68a7b4a into main Dec 12, 2024
46 checks passed
@jerelmiller jerelmiller deleted the jerel/remove-itasync-part-1 branch December 12, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants