Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adjust screenshot size #12178

Merged
merged 1 commit into from
Dec 6, 2024
Merged

docs: adjust screenshot size #12178

merged 1 commit into from
Dec 6, 2024

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Dec 6, 2024

before this change (yes, it's really so blurry!):
image

after: https://www.apollographql.com/docs/deploy-preview/1b53496c8035da7b414e/react/development-testing/developer-tooling

image

Still not perfect, but way better

@phryneas phryneas requested a review from a team as a code owner December 6, 2024 16:47
@svc-apollo-docs
Copy link

svc-apollo-docs commented Dec 6, 2024

✅ Docs Preview Ready

Configuration
{
  "repoOverrides": {
    "apollographql/apollo-client@main": {
      "remote": {
        "owner": "apollographql",
        "repo": "apollo-client",
        "branch": "pr/fix-screenshot-size"
      }
    }
  }
}
Name Link

Commit

766305d

Preview

https://www.apollographql.com/docs/deploy-preview/1b53496c8035da7b414e

Build ID

1b53496c8035da7b414e

File Changes

0 new, 1 changed, 0 removed
* (developer-tools)/react/(latest)/development-testing/developer-tooling.md

Pages

1


1 pages published. Build will be available for 30 days.

Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: 766305d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 766305d
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/67532a93111a2600087338be
😎 Deploy Preview https://deploy-preview-12178--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 40.64 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 50.02 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 47.14 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.14 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.54 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.29 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.7 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.78 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.84 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.42 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.41 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.35 KB (0%)
import { useFragment } from "dist/react/index.js" 2.36 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.31 KB (0%)

Copy link

pkg-pr-new bot commented Dec 6, 2024

npm i https://pkg.pr.new/@apollo/client@12178

commit: 766305d

@phryneas phryneas requested a review from jerelmiller December 6, 2024 16:50
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to get a screenshot with the newest version of the devtools at some point, but this works great for now 🙂

@github-actions github-actions bot added the auto-cleanup 🤖 label Dec 6, 2024
@jerelmiller jerelmiller merged commit 10c8755 into main Dec 6, 2024
48 checks passed
@jerelmiller jerelmiller deleted the pr/fix-screenshot-size branch December 6, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants