Handle additional cases in unmasked types

[phryneas]

For context, this had some Discord help:

https://discord.com/channels/997886693233393714/1309495105027313725
(if you're not on the server yet: https://t.co/0PGvmQUEIO)

[svc-apollo-docs]

✅ Docs Preview Ready

No new or changed pages found.

[changeset-bot]

🦋 Changeset detected

Latest commit: 7769b76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

npm i https://pkg.pr.new/@apollo/client@12154

commit: 5fe3bcc

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	40.64 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	50.8 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	47.68 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	36.15 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	33.56 KB (0%)
import { ApolloProvider } from "dist/react/index.js"	1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.24 KB (0%)
import { useQuery } from "dist/react/index.js"	5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.3 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.71 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.78 KB (0%)
import { useMutation } from "dist/react/index.js"	3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.85 KB (0%)
import { useSubscription } from "dist/react/index.js"	4.43 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.42 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.36 KB (0%)
import { useFragment } from "dist/react/index.js"	2.37 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.31 KB (0%)

[phryneas]

These missing caused problems - the question is: would they be missing in a real life case with codegen, or just with our hand-written types?

[jerelmiller]

Unless someone turns off the skipTypename option (possible, but I'd suggest we enforce this as a requirement), this should only be a problem with our hand-written types (or hand-written types in general, which again we can encourage not to do).

Good catch on this though. I'll comb through the new masking tests and make sure __typename is added everywhere. This is just a goof on my part.

[jerelmiller]

Code looks good. There are some failing tests, but I'll look into it and fix them before merging. Appreciate you going further on this one!