Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for watchFragment with non-identifiable object #12002

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/__tests__/ApolloClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2515,6 +2515,36 @@ describe("ApolloClient", () => {
});
}
});

it("reports complete as false when `from` is not identifiable", async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it("reports complete as false when `from` is not identifiable", async () => {
it.failing("reports complete as false when `from` is not identifiable", async () => {

const cache = new InMemoryCache();
const client = new ApolloClient({
cache,
link: ApolloLink.empty(),
});
const ItemFragment = gql`
fragment ItemFragment on Item {
id
text
}
`;

const observable = client.watchFragment({
fragment: ItemFragment,
from: {},
});

const stream = new ObservableStream(observable);

{
const result = await stream.takeNext();

expect(result).toStrictEqual({
data: {},
complete: false,
});
}
});
});

describe("defaultOptions", () => {
Expand Down
Loading