Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11849, BatchHttpLink not monitoring friendly #11860

Merged
merged 3 commits into from
May 20, 2024

Conversation

alessbell
Copy link
Contributor

Closes #11849.

Replicates the diff in #8603 in BatchHttpLink - set this as a patch change since it seems like a bug given the discrepancy with HttpLink.

@alessbell alessbell requested review from jerelmiller and phryneas May 20, 2024 17:29
Copy link

changeset-bot bot commented May 20, 2024

🦋 Changeset detected

Latest commit: afbf224

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 20, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.65 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 47.42 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 44.99 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.2 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.05 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.28 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.36 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.52 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.59 KB (0%)
import { useMutation } from "dist/react/index.js" 3.52 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.74 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.21 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.4 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.44 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.1 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.96 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.61 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.07 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.72 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.33 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.27 KB (0%)
import { useFragment } from "dist/react/index.js" 2.29 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.23 KB (0%)

@alessbell alessbell changed the title Fixes #11849 ,BatchHttpLink not monitoring friendly Fixes #11849, BatchHttpLink not monitoring friendly May 20, 2024
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this in!

Copy link

netlify bot commented May 20, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 3f5f00f
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/664b8877d22d5500086d8ed4
😎 Deploy Preview https://deploy-preview-11860--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the auto-cleanup 🤖 label May 20, 2024
Copy link

netlify bot commented May 20, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit afbf224
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/664b8918158f600008889191
😎 Deploy Preview https://deploy-preview-11860--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alessbell alessbell merged commit 8740f19 into main May 20, 2024
41 checks passed
@alessbell alessbell deleted the issue-11849-batchhttplink-not-monitoring-friendly branch May 20, 2024 17:42
@github-actions github-actions bot mentioned this pull request May 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BatchHTTPLink is not monitoring friendly
2 participants