Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept min and max delay in createSchemaFetch options #11774

Merged

Conversation

alessbell
Copy link
Contributor

Closes #11748.

Copy link

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: d8891ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alessbell alessbell requested a review from jerelmiller April 10, 2024 14:42
Copy link
Contributor

github-actions bot commented Apr 10, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.61 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 46.49 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 44.04 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.16 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.04 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.24 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.27 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.35 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.58 KB (0%)
import { useMutation } from "dist/react/index.js" 3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.73 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.44 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.11 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.92 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.58 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.03 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.69 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.32 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.26 KB (0%)
import { useFragment } from "dist/react/index.js" 2.29 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.24 KB (0%)

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit d8891ea
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/661d86ca7414bc00088a6feb
😎 Deploy Preview https://deploy-preview-11774--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alessbell alessbell changed the title [Testing utilities] Accept min and max delay in createSchemaFetch options Accept min and max delay in createSchemaFetch options Apr 10, 2024
@alessbell alessbell requested a review from phryneas April 10, 2024 16:00
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I LOVE this addition. I had a few suggestions as well to see if we can make a couple more incremental improvements.

src/testing/core/createSchemaFetch.ts Outdated Show resolved Hide resolved
src/testing/core/createSchemaFetch.ts Outdated Show resolved Hide resolved
src/testing/core/createSchemaFetch.ts Outdated Show resolved Hide resolved
src/testing/core/__tests__/createTestSchema.test.tsx Outdated Show resolved Hide resolved
src/testing/core/__tests__/createTestSchema.test.tsx Outdated Show resolved Hide resolved
src/testing/core/__tests__/createTestSchema.test.tsx Outdated Show resolved Hide resolved
@phryneas
Copy link
Member

@alessbell thanks for the callout, that was a profiler bug - sorry for the frustration!
Fixed in 534626c

@alessbell alessbell requested a review from jerelmiller April 12, 2024 12:33
Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick in the test, otherwise approved :)

src/testing/core/__tests__/createTestSchema.test.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added the auto-cleanup 🤖 label Apr 15, 2024
@apollographql apollographql deleted a comment from github-actions bot Apr 15, 2024
@alessbell alessbell merged commit 2583488 into release-3.10 Apr 15, 2024
35 checks passed
@alessbell alessbell deleted the issue-11748-min-max-createSchemaFetch-threshold branch April 15, 2024 20:16
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Testing utilities] Add min/max thresholds to options accepted by createMockFetch
3 participants