use native AbortController #11753
use native AbortController #11753
Conversation
|
| // that includes the `signal` option, which (with the native `AbortController`) | ||
| // has a reference to the `Request` instance, which will somehow reference our | ||
| // hash object | ||
| fetchMock.resetHistory(); |
There was a problem hiding this comment.
Not sure how much overhead this would add, but: thoughts on calling this in an afterEach to make these tests future-proof?
There was a problem hiding this comment.
I don't think so - in this case, it was even within the test.
In the long run, we should probably move away from mock-fetch, so I wouldn't spend too much time with it now, tbh.
There was a problem hiding this comment.
Ah right! Forgot that it wasn't just at the top of the test :/ makes sense 👍
… in the environemt (#11751) * fix: use custom jsdom env insted of patching it via patch package * Clean up Prettier, Size-limit, and Api-Extractor * use native `AbortController` (#11753) --------- Co-authored-by: Lenz Weber-Tronic <[email protected]> Co-authored-by: phryneas <[email protected]>
This is a follow-up to #11751
Using the native
AbortControllerpreviously created a memory leak in our tests, becausemock-fetchkeeps a history of requests - which referenced thesignal- and thesignalkeeps a reference to theAbortController, so theAbortControlleritself was never cleared up, and theRequestsomehow stayed in memory, including a reference to ourref.