-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devtools - Trigger Error Code PR after npm Release #11745
Conversation
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm :)
Seems this is still missing permissions - I've opened a ticket internally. |
Do we need repository permissions for apollo client as well when generating the token? That was going to be my one comment before but figured it was worth trying more narrowly-scoped perms first. |
I don't think so - it shouldn't matter from where it is triggered from, and we don't access anything specific to the AC repo. Guess we'll find out soon, though :) I think we're just missing the |
Potentially related: benc-uk/workflow-dispatch#52 |
This is one of those where we won't know if they work until we merge them 😞