Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtools - Trigger Error Code PR after npm Release #11745

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Apr 2, 2024

This is one of those where we won't know if they work until we merge them 😞

Copy link

changeset-bot bot commented Apr 2, 2024

⚠️ No Changeset found

Latest commit: ac3ac8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 2, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.45 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 46.28 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 43.83 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 33.96 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.87 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.27 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.35 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.5 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.58 KB (0%)
import { useMutation } from "dist/react/index.js" 3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.73 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.44 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.11 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.92 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.58 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.03 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.69 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.17 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.11 KB (0%)
import { useFragment } from "dist/react/index.js" 2.27 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.22 KB (0%)

Copy link
Contributor

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm :)

@github-actions github-actions bot added the auto-cleanup 🤖 label Apr 2, 2024
@phryneas phryneas merged commit 285b2d9 into main Apr 2, 2024
34 of 35 checks passed
@phryneas
Copy link
Member Author

phryneas commented Apr 2, 2024

Seems this is still missing permissions - I've opened a ticket internally.

@alessbell
Copy link
Contributor

Do we need repository permissions for apollo client as well when generating the token? That was going to be my one comment before but figured it was worth trying more narrowly-scoped perms first.

@phryneas
Copy link
Member Author

phryneas commented Apr 2, 2024

I don't think so - it shouldn't matter from where it is triggered from, and we don't access anything specific to the AC repo. Guess we'll find out soon, though :)

I think we're just missing the actions:write permission - see https://docs.github.com/en/rest/actions/workflows?apiVersion=2022-11-28#create-a-workflow-dispatch-event

@alessbell
Copy link
Contributor

Potentially related: benc-uk/workflow-dispatch#52

@jerelmiller jerelmiller deleted the pr/trigger-devtools-action branch April 2, 2024 17:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants