potential optimization - bail out of executeSubSelectedArray calls

[phryneas]

This just came up in #11669 and I wanted to try it out.

One thing to consider strongly here is that this returns the original empty array, so I'll have to investigate if that could make it out of the cache where users could accidentally start manipulating it (and if we see this as a problem).

We could have a "weak empty array mapping cache" somewhere to prevent that, but at that point I'm not sure if this optimization does make any sense at all.

[changeset-bot]

🦋 Changeset detected

Latest commit: aa388af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[phryneas]

/release:pr

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	38.4 KB (+0.02% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	46.23 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	43.79 KB (+0.02% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	33.96 KB (+0.03% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	31.87 KB (+0.02% 🔺)
import { ApolloProvider } from "dist/react/index.js"	1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.22 KB (0%)
import { useQuery } from "dist/react/index.js"	5.26 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.35 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.5 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.58 KB (0%)
import { useMutation } from "dist/react/index.js"	3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.73 KB (0%)
import { useSubscription } from "dist/react/index.js"	3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.41 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.07 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	4.89 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.55 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.02 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.68 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.17 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.11 KB (0%)
import { useFragment } from "dist/react/index.js"	2.27 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.22 KB (0%)

[github-actions]

A new release has been made for this PR. You can install it with:

npm i @apollo/[email protected]

[benjamn]

This looks safe to me. The StoreReader often returns fieldValue to application code without making a defensive copy, but frozen (in development), so copying fieldValue in this case seems unusual/unnecessary.

[benjamn]

You could probably rearrange this so it only calls handleMissing and updates fieldValue if fieldValue.length > 0, but I leave that 🏌️ up to you.

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	8c6860c
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/66015c6b62452e000841cf24
😎 Deploy Preview	https://deploy-preview-11670--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	aa388af
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/66015d0d85af5a00082c2cf9
😎 Deploy Preview	https://deploy-preview-11670--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[jerelmiller]

Nice! 🎉