fix: unbound-method lint error by using arrow function syntax for fns declared on the ObservableQueryFields interface

[alessbell]

Closes #11554.

[changeset-bot]

🦋 Changeset detected

Latest commit: 50b389d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	38.14 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	45.95 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	43.49 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	33.88 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	31.8 KB (0%)
import { ApolloProvider } from "dist/react/index.js"	1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.21 KB (0%)
import { useQuery } from "dist/react/index.js"	5.2 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.27 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.5 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.58 KB (0%)
import { useMutation } from "dist/react/index.js"	3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.73 KB (0%)
import { useSubscription } from "dist/react/index.js"	3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.28 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	3.94 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	4.75 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.4 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	4.97 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.63 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.04 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	2.98 KB (0%)
import { useFragment } from "dist/react/index.js"	2.18 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.13 KB (0%)

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	50b389d
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/65c15120aefcc400087b766e
😎 Deploy Preview	https://deploy-preview-11558--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[alessbell]

Confirmed this would impact the docs. Any ideas on how we can make both happy, @phryneas? We could try @jerelmiller's idea of a "fake this" but that would also impact the type that ends up in the docs.

[phryneas]

Alternative options:

Arrow function

Suggested change

	startPolling: ObservableQuery<TData, TVariables>["startPolling"];
	startPolling: (pollInterval: number) => void;

this: void,

Suggested change

	startPolling: ObservableQuery<TData, TVariables>["startPolling"];
	startPolling(this: void, pollInterval: number): void;

[alessbell]

Thanks @phryneas, this is ready for a final look!

[jerelmiller]

Looks great!

[jerelmiller]

Suggested change

// startPolling(pollInterval: number): void;

I think we could probably get rid of the commented old code 🙂. What do you think?

[alessbell]

Oops, totally overlooked those :) Removed in 556b085

[jerelmiller]

🚢 it