Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove error thrown by inFlightLinkObservables #11545

Merged

Conversation

alessbell
Copy link
Contributor

@alessbell alessbell commented Jan 31, 2024

Closes #11543.

Edit: unrelated to the above issue but still cleanup nonetheless :)

@alessbell alessbell requested a review from a team as a code owner January 31, 2024 14:39
Copy link

changeset-bot bot commented Jan 31, 2024

🦋 Changeset detected

Latest commit: 6cc0999

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 31, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.15 KB (-0.24% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 45.97 KB (-0.15% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 43.5 KB (-0.19% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 33.88 KB (-0.25% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.8 KB (-0.29% 🔽)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.21 KB (0%)
import { useQuery } from "dist/react/index.js" 5.2 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.27 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.5 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.58 KB (0%)
import { useMutation } from "dist/react/index.js" 3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.73 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.28 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 3.94 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.75 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.4 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 4.97 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.63 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.04 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 2.98 KB (0%)
import { useFragment } from "dist/react/index.js" 2.18 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.13 KB (0%)

@efstathiosntonas
Copy link
Contributor

@alessbell thank you for looking into this. I removed these lines and the error persisted. Let me give it one more shot though.

@efstathiosntonas
Copy link
Contributor

@alessbell tried it again, removed the lines from core.cjs, restarted metro server with --reset-cache but the issue persists.

@alessbell
Copy link
Contributor Author

@efstathiosntonas thanks for opening the issue, that's helpful info. If you have a reproduction you can share (the empty react-native project where you transferred over your client setup, if you're able to share it), that would also help a lot, otherwise I can spin one up. Thanks!

@efstathiosntonas
Copy link
Contributor

@alessbell here's a demo repo, please note that i cannot reproduce it: https://github.com/efstathiosntonas/bare-react-native-expo-svg-transformer-issue (don't mind about the repo name)

@github-actions github-actions bot added the auto-cleanup 🤖 label Jan 31, 2024
@alessbell alessbell merged commit 84a6bea into main Jan 31, 2024
27 checks passed
@alessbell alessbell deleted the issue-11543-inFlightLinkObservables-remove-thrown-error branch January 31, 2024 16:33
@github-actions github-actions bot mentioned this pull request Jan 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.9.0] inFlightLinkObservables_1.remove is not a function (it is undefined) in react-native
3 participants