-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove retain
from useLoadableQuery
to allow for auto disposal
#11442
Conversation
🦋 Changeset detectedLatest commit: 4c198e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in :)
Thanks to the work in #11412, we no longer need to
retain
thequeryRef
produced byuseLoadableQuery
since this is handled inuseReadQuery
for us. This means that aqueryRef
not consumed byuseReadQuery
within the givenautoDisposeTimeoutMs
will now be auto disposed, removing the need for the query to hang out as active while not used. #11412 enabled the ability to auto resubscribe to a disposedqueryRef
, so when thequeryRef
is consumed after it has been disposed, it will automatically resubscribe.Checklist: