Simplify RetryLink, fix potential memory leak

[phryneas]

fixes #11393

Historically, RetryLink would keep a values array of all previous values,
in case the operation would get an additional subscriber at a later point in time.
In practice, this could lead to a memory leak (#11393) and did not serve any
further purpose, as the resulting observable would only be subscribed to by
Apollo Client itself, and only once - it would be wrapped in a Concast before
being exposed to the user, and that Concast would handle subscribers on its
own.

This could be seen as a breaking change if someone was using RetryLink
independently of Apollo Client, but we don't document or encourage that in any
way, so I assume this should be fine in a minor.

Checklist:

• If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
• If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests

[changeset-bot]

🦋 Changeset detected

Latest commit: e78e8b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	38.21 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	46 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	43.56 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	33.96 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	31.89 KB (0%)
import { ApolloProvider } from "dist/react/index.js"	1.24 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.22 KB (0%)
import { useQuery } from "dist/react/index.js"	5.2 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.27 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.51 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.58 KB (0%)
import { useMutation } from "dist/react/index.js"	3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.73 KB (0%)
import { useSubscription } from "dist/react/index.js"	3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	2.39 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.28 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	3.94 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	4.75 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.39 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	4.98 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.64 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.03 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	2.97 KB (0%)
import { useFragment } from "dist/react/index.js"	2.1 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.05 KB (0%)

[phryneas]

/release:pr

[github-actions]

A new release has been made for this PR. You can install it with npm i @apollo/[email protected].

[jerelmiller]

🎉 Nice to see so much code removed!

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	e78e8b3
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/6582c5186de6e900080a65d5
😎 Deploy Preview	https://deploy-preview-11424--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.