-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persisted Query Link: improve memory management #11369
Conversation
🦋 Changeset detectedLatest commit: 6d2ec4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
I have a feeling that |
@@ -12,7 +13,12 @@ import { createHttpLink } from "../../http/createHttpLink"; | |||
import { graphql } from "../../../react/hoc/graphql"; | |||
import { getDataFromTree } from "../../../react/ssr/getDataFromTree"; | |||
import { createPersistedQueryLink as createPersistedQuery, VERSION } from ".."; | |||
import { sha256 } from "./persisted-queries.test"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests failed because we had some kind of concurrency problem - by importing from another test file, all the tests from that other file were added to this file, and then failed for reasons I'll never understand.
That's two hours wasted debugging I'll never get back 🤦
c80ba36
to
3f7eecb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR is ready for review & merging :)
Checklist: