useSuspenseQuery: remove promiseCache

[phryneas]

Also looking at the other suspense hooks, but putting this here already so @jerelmiller can take a look.

Checklist:

• If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
• If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3f5b734

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	37.77 KB (-0.05% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	44.26 KB (-0.02% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	42.73 KB (-0.06% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	32.87 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	31.55 KB (0%)
import { ApolloProvider } from "dist/react/index.js"	1.28 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.26 KB (0%)
import { useQuery } from "dist/react/index.js"	4.38 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.19 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	4.69 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.51 KB (0%)
import { useMutation } from "dist/react/index.js"	2.65 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.63 KB (0%)
import { useSubscription } from "dist/react/index.js"	2.34 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	2.29 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	4.33 KB (-0.85% 🔽)
import { useSuspenseQuery } from "dist/react/index.js" (production)	3.75 KB (-0.96% 🔽)
import { useBackgroundQuery } from "dist/react/index.js"	3.86 KB (-0.21% 🔽)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.26 KB (-0.18% 🔽)
import { useLoadableQuery } from "dist/react/index.js"	4.11 KB (-0.19% 🔽)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.52 KB (-0.2% 🔽)
import { useReadQuery } from "dist/react/index.js"	3.05 KB (-0.07% 🔽)
import { useReadQuery } from "dist/react/index.js" (production)	3 KB (+0.07% 🔺)
import { useFragment } from "dist/react/index.js"	2.15 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.1 KB (0%)

[jerelmiller]

This change looks good to me. Thanks for digging into this further and making some improvements here. Sometimes I forget that a new empty object is enough to be a unique identifier in a lot of cases, rather than the "original" thing. Thanks!

[jerelmiller]

Since the key is no longer needed from options, could you remove this from InternalQueryReferenceOptions and stop passing it from SuspenseCache?