-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't crash if some (but not all) Error Codes are loaded #11291
Don't crash if some (but not all) Error Codes are loaded #11291
Conversation
@ArioA: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-client-docs pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: 2792bda The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a very good catch, thank you for the PR!
Could you accept the CLA? I'll see that I fix it up for merging :)
@phryneas thanks! 😃 I've accepted the CLA |
And I've added a Changeset :) |
Those last two failing PRs are not your fault - getting this merged :) |
Problem
I call
loadErrorMessages()
but notloadDevErrorMessages()
on application startup. When a "dev" error code is encountered, I get the following error:Proposed Solution
It seems reasonable for unloaded error codes revert to the fallback, rather than causing the app to crash.