Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay in docs for loading state testing #11287

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Oct 13, 2023

Fixes #11285.

Also includes two new tests to ensure the proposed way of testing actually works (and keeps working).

@gzm0 gzm0 requested a review from a team as a code owner October 13, 2023 14:09
@apollo-cla
Copy link

@gzm0: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@netlify
Copy link

netlify bot commented Oct 13, 2023

👷 Deploy request for apollo-client-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8fe4798

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

⚠️ No Changeset found

Latest commit: 8fe4798

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gzm0
Copy link
Contributor Author

gzm0 commented Oct 13, 2023

  • I've signed the CLA.
  • Changeset IMO not necessary for this change.

@gzm0
Copy link
Contributor Author

gzm0 commented Oct 16, 2023

OK, now I have actually signed the CLA (sorry, I thought logging in was enough).

Copy link
Contributor

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @gzm0!

Edit: investigating the security-scans job failure which has nothing to do with this PR, should be resolved shortly

@phryneas phryneas merged commit 89374ca into apollographql:main Oct 17, 2023
5 of 6 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.8.x has broken tests of components that return different tags based on loading state
4 participants