-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delay in docs for loading state testing #11287
Conversation
Following the discussion in apollographql#11285.
@gzm0: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-client-docs pending review.Visit the deploys page to approve it
|
|
|
OK, now I have actually signed the CLA (sorry, I thought logging in was enough). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @gzm0!
Edit: investigating the security-scans job failure which has nothing to do with this PR, should be resolved shortly
Fixes #11285.
Also includes two new tests to ensure the proposed way of testing actually works (and keeps working).