Decouple canonicalStringify from ObjectCanon

[benjamn]

Because the ObjectCanon happens to produce canonical objects whose keys have been sorted alphabetically/lexicographically, it seemed convenient and efficient for implementing a stable JSON.stringify utility (see PR #8222), but the additional memory overhead of fully canonizing (duplicating) the objects was probably not justified, especially since (as this PR suggests) an independent implementation of canonicalStringify can be even faster while using much less memory.

[changeset-bot]

🦋 Changeset detected

Latest commit: d0aa030

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	37.14 KB (+0.08% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	43.5 KB (+0.08% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	42.03 KB (+0.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	32.57 KB (+0.1% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	31.31 KB (+0.1% 🔺)
import { ApolloProvider } from "dist/react/index.js"	1.22 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.21 KB (0%)
import { useQuery } from "dist/react/index.js"	4.28 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.09 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	4.59 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.41 KB (0%)
import { useMutation } from "dist/react/index.js"	2.53 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.51 KB (0%)
import { useSubscription } from "dist/react/index.js"	2.24 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	2.2 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	4.25 KB (-7.58% 🔽)
import { useSuspenseQuery } from "dist/react/index.js" (production)	3.69 KB (-8.3% 🔽)
import { useBackgroundQuery } from "dist/react/index.js"	3.73 KB (-9.32% 🔽)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.18 KB (-9.97% 🔽)
import { useReadQuery } from "dist/react/index.js"	2.97 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	2.92 KB (0%)
import { useFragment } from "dist/react/index.js"	2.08 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.03 KB (0%)

[phryneas]

/release:pr

[github-actions]

A new release has been made for this PR. You can install it with npm i @apollo/[email protected].

[benjamn]

Fun TC39/ECMAScript fact: thanks to this proposal which recently reached stage 4, we will eventually be able to use keys.toSorted() instead of keys.slice(0).sort(). "Eventually" because even evergreen browsers take some time to ship new features.

[phryneas]

At least it's one of those things that can easily be polyfilled in userland, so we can make that switch in two years or so :)

[phryneas]

This is gonna have a big impact, especially in SSR scenarios.
Thanks for taking the time to go over this!

[jerelmiller]

This looks great to me! Nothing to add that @phryneas hasn't already. 🎉

[phryneas]

Then let's get this into the 3.9 branch so we can have a few people try it out soon :)