-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nextFetchPolicy
behaviour with transformed documents
#11235
Conversation
🦋 Changeset detectedLatest commit: 5c86019 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/release:pr |
A new release has been made for this PR. You can install it with |
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
query EchoQuery { | ||
linkCounter | ||
opName | ||
opVars | ||
echo { | ||
linkCounter | ||
opName | ||
opVars | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, this test did not trigger any query transformation and did not surface this bug.
The additional nesting results in a __typename
being inserted - and as a result, this test would fail without the fix in this PR.
const fetchOptions = | ||
query === options.query ? options : { ...options, query }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests did take the query === options.query
path here, so this didn't surface.
options
reference stable when passing it through QueryManagernextFetchPolicy
behaviour with transformed documents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great find on this one! Thanks for fixing 🎉
Fixes #11234
I adjusted existing tests to catch possible regressions.
Checklist: