Update README logo #11213
Merged
Update README logo #11213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
phryneas
reviewed
Sep 13, 2023
|
|
||
| ## Apollo Client | ||
| <p> | ||
| <a href="https://www.apollographql.com/"><img src="https://raw.githubusercontent.com/apollographql/apollo-client-devtools/main/assets/apollo-wordmark.svg" height="100" alt="Apollo Client"></a> |
There was a problem hiding this comment.
shouldn't we maybe have the logo in this repo, so changing the folder structure in the other repo can't break something here?
There was a problem hiding this comment.
I can add a comment in the SVG, or create an assets here if you feel strongly about it :)
There was a problem hiding this comment.
I'd prefer an assets repo to be honest, but that will just get abandoned and archived I fear 😓
I think a comment over there is fine :)
phryneas
approved these changes
Sep 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the README to use the new logo, which also adjusts its color via
prefers-color-schememedia query. The logo SVG is borrowed from the devtools repository: https://github.com/apollographql/apollo-client-devtools/blob/main/assets/apollo-wordmark.svgBefore
After