Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused reject argument for mockQueryManager and mockWatchQuery #10504

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

jerelmiller
Copy link
Member

@jerelmiller jerelmiller commented Feb 3, 2023

While working on #10502, I noticed that mockQueryManager and mockWatchQuery both took a reject argument, but this argument wasn't used. For added simplicity, I simply removed this argument and updated all references to it accordingly.

These are internal testing utilities, so the breaking change to the API won't affect users.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2023

⚠️ No Changeset found

Latest commit: 257a524

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jerelmiller jerelmiller requested a review from alessbell February 3, 2023 00:51
Copy link
Contributor

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! LGTM

@jerelmiller jerelmiller force-pushed the minor-adjustment-to-internal-api branch from fa907bf to 257a524 Compare February 3, 2023 00:56
@jerelmiller jerelmiller merged commit e079cc1 into main Feb 3, 2023
@jerelmiller jerelmiller deleted the minor-adjustment-to-internal-api branch February 3, 2023 01:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants