fix one-tick-race condition in asyncMap

apollographql · Sep 25, 2023 · 7e0695a · 7e0695a
1 parent 770cb72
commit 7e0695a
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/utilities/observables/asyncMap.ts b/src/utilities/observables/asyncMap.ts
@@ -33,20 +33,21 @@ export function asyncMap<V, R>(
             .then(both, both)
             .then(
               (result) => {
-                --activeCallbackCount;
                 next && next.call(observer, result);
-                if (completed) {
-                  handler.complete!();
-                }
               },
               (error) => {
-                --activeCallbackCount;
                 throw error;
               }
             )
             .catch((caught) => {
               error && error.call(observer, caught);
             });
+          promiseQueue.finally(() => {
+            --activeCallbackCount;
+            if (completed) {
+              handler.complete!();
+            }
+          });
         };
       } else {
         return (arg) => delegate && delegate.call(observer, arg);