Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cleanup out of Observer subscription initializer #96

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Move cleanup out of Observer subscription initializer #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package/src/ssr/NextSSRApolloClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ export class NextSSRApolloClient<
);
});

promise.finally(cleanup);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should always get executed, but in the old codepath it would only be executed if a subscriber was attached to the Observable.

byVariables.set(
varJson,
(observable = new Observable<FetchResult>((observer) => {
Expand All @@ -134,8 +135,7 @@ export class NextSSRApolloClient<
})
.catch((err) => {
observer.error(err);
})
.finally(cleanup);
});
}))
);

Expand Down