Use server-only package instead of custom environment detection

[leonchabbey]

I saw this issue when trying to fetch data from the sitemap.ts file using the getClient / registerApolloClient (like it's done for server only code).
Apparently the "client version" of React is somehow available when the sitemap is getting generated which was triggering the custom detection currently implemented.

I tried using import 'server-only instead as it is the recommended way to make sure something isn't imported from a client component and all cases seem to work:

• From CC -> crash (✅ )
• From RSC -> ✅
• From sitemap.ts -> ✅

[phryneas]

Apparently the "client version" of React is somehow available when the sitemap is getting generated which was triggering the custom detection currently implemented.

That would be very worrying as that client version has no working version of React.cache 🤔

Apart form that: this is a great change, and will also play nicely with apollographql/apollo-client#11175 - thank you!

I just wonder why CI didn't kick off?

[leonchabbey]

That would be very worrying as that client version has no working version of React.cache 🤔

Yep it's really weird. I didn't investigate much more what was happening on NextJS' side but it looks like it might be a bug on their side. We obviously can't (and also don't want to) run React to generate a sitemap 😄

I will open an issue on their side about this React context issue

[phryneas]

I'll see that I get this out as a new patch release - thanks a ton for the PR! :)

[phryneas]

And released in https://github.com/apollographql/apollo-client-nextjs/releases/tag/v.0.4.2 :)

[leonchabbey]

Great! Thanks a lot for being so quick getting this merged 👏