Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] SlippageControl enum #56

Closed
wants to merge 2 commits into from
Closed

Conversation

apollo-sturdy
Copy link
Contributor

@apollo-sturdy apollo-sturdy commented Nov 14, 2022

Allows us to choose how to specify slippage control via an enum.
Todo is to implement for Osmosis. For that we will need to add yet another PR to Osmosis, so this is blocked by that.

@pacmanifold pacmanifold changed the base branch from master to develop November 15, 2022 11:43
@apollo-sturdy apollo-sturdy marked this pull request as draft November 15, 2022 16:05
@apollo-sturdy apollo-sturdy added enhancement New feature or request blocked labels Nov 15, 2022
@apollo-sturdy apollo-sturdy changed the title [WIP] Unify slippage control [WIP] SlippageControl enum Nov 15, 2022
@apollo-sturdy
Copy link
Contributor Author

Closing for now. Will re-open after we have made the PR to Osmosis. Created issue for it: #80

@apollo-sturdy apollo-sturdy deleted the dec/slippage-control branch July 3, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant