WIP

apitally · Nov 1, 2024 · 99c9fce · 99c9fce
1 parent cab5fc9
commit 99c9fce
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/express/middleware.ts b/src/express/middleware.ts
@@ -137,13 +137,13 @@ const getRoutePath = (req: Request) => {
     return;
   }
   if (req.baseUrl) {
-    const routerPaths = getRouterPaths(req.app._router.stack, req.baseUrl);
-    return routerPaths.join("") + req.route.path;
+    const routerPath = getRouterPath(req.app._router.stack, req.baseUrl);
+    return routerPath + req.route.path;
   }
   return req.route.path;
 };
 
-const getRouterPaths = (stack: any[], baseUrl: string) => {
+const getRouterPath = (stack: any[], baseUrl: string) => {
   const routerPaths: string[] = [];
   while (stack && stack.length > 0) {
     const routerLayer = stack.find(
@@ -165,7 +165,7 @@ const getRouterPaths = (stack: any[], baseUrl: string) => {
       break;
     }
   }
-  return routerPaths;
+  return routerPaths.join("");
 };
 
 const getConsumer = (req: Request) => {

diff --git a/tests/express/app.test.ts b/tests/express/app.test.ts
@@ -194,7 +194,7 @@ describe("Middleware for Express with nested routers", () => {
 
   it("Request logger", async () => {
     await appTest.get("/api/v1/hello/bob").expect(200);
-    await appTest.get("/api/v1/goodbye/world").expect(200);
+    await appTest.get("/api/v2/goodbye/world").expect(200);
 
     const requests = client.requestCounter.getAndResetRequests();
     expect(requests.length).toBe(2);